Set the preferred URL scheme in production to https
#449
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
We are seeing an issue where calls to
url_for
using_external=True
for certain conditions are generating links to files that include the scheme, but usehttp
for it instead ofhttp
. This is causing a mixed content warning with our certificate. I tracked it down to pages that are serving the default placeholder image for officers, e.g.:OpenOversight/OpenOversight/app/templates/officer.html
Line 8 in 6cd9857
This PR changes the
PREFERRED_URL_SCHEME
setting tohttps
for production environments.Tests and linting
I have rebased my changes on
main
just lint
passesjust test
passes